Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't use interface pointer #106

Merged
merged 2 commits into from
Dec 2, 2020
Merged

don't use interface pointer #106

merged 2 commits into from
Dec 2, 2020

Conversation

xxjwxc
Copy link
Contributor

@xxjwxc xxjwxc commented Dec 2, 2020

don't use interface pointer

@xxjwxc
don't use interface pointer
4d74bd1 
don't use interface pointer
@CLAassistant
Copy link

CLAassistant commented Dec 2, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@abhinav
only change the interface based example
4968d73 
The other sample specifically has a struct defined so a pointer to that is okay.
abhinav
abhinav approved these changes Dec 2, 2020
View reviewed changes
Copy link
Collaborator

@abhinav abhinav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And a good catch on the returns.

I made a minor change: the first example is specifically for struct pointer embedding so I switched that back.

prashantv
prashantv approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@prashantv prashantv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fixes

@abhinav abhinav merged commit e460299 into uber-go:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinav abhinav abhinav approved these changes

@prashantv prashantv prashantv approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xxjwxc @CLAassistant @abhinav @prashantv